RequestAsync support basic auth #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for HTTP Basic Authentication by extracting credentials from the URI's UserInfo component and converting them into a proper Authorization header, resolving an issue where the builder returns URLs not supported by the HTTP client.
Key Changes:
- Extracts username and password from URI's UserInfo property
- Converts credentials to Base64-encoded Authorization header
- Strips credentials from the URI before creating the HTTP request
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
766974616c79
force-pushed
the
RequestAsync-support-basic-auth
branch
2 times, most recently
from
5cfde5c to
64ca180
Compare
Contributor
Author
|
@garrynewman i made the recommended changes, sorry for the time taken |
766974616c79
force-pushed
the
RequestAsync-support-basic-auth
branch
from
64ca180 to
79379eb
Compare
Member
|
Send the header manually if you want to use basic auth, the same way you would with a normal .NET HttpClient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the above code, the builder returns a URL that is not supported by the HTTP client. You must use the Authorisation header to be able to use authentication.
Resolves Facepunch/sbox-issues#5798